Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] Add window resize listener to adjust qrcode dimensions #936

Closed
xzilja opened this issue Mar 14, 2023 · 1 comment
Closed

[bug] Add window resize listener to adjust qrcode dimensions #936

xzilja opened this issue Mar 14, 2023 · 1 comment
Labels
bug Something isn't working P2 Small feature / nice to have
Milestone
2.3.0

Comments

@xzilja
Copy link
Contributor

xzilja commented Mar 14, 2023 •
edited
Loading

Summary

Uppon resizing the window or when modal toggles between mobile and desktop layouts, the size of qrcode remains the same. We should add resize listener to adjust this as needed.

Screenshot 2023-03-13 at 17 49 17

Screenshot 2023-03-13 at 17 43 28
@xzilja xzilja added bug Something isn't working needs review and removed needs review labels Mar 14, 2023
@xzilja xzilja added this to the 2.2.1 milestone Mar 14, 2023
@xzilja xzilja added the P2 Small feature / nice to have label Jun 13, 2023
@xzilja
Copy link
Contributor Author

xzilja commented Sep 11, 2023

Implemented in v3

@xzilja xzilja closed this as completed Sep 11, 2023
@jackromo888 jackromo888 mentioned this issue May 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working P2 Small feature / nice to have
Projects
None yet
Milestone
2.3.0
Development

No branches or pull requests
1 participant
@xzilja