Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't deserialize utf8 data as native strings in Rust backend #2538

Closed
teh-cmc opened this issue Jun 27, 2023 · 2 comments
Closed

Don't deserialize utf8 data as native strings in Rust backend #2538

teh-cmc opened this issue Jun 27, 2023 · 2 comments
Labels

Comments

@teh-cmc
Copy link
Member

teh-cmc commented Jun 27, 2023

We currently do the obvious and slow thing: deserializing utf8arrays as native strings, which means a lot of copies, utf8 checks, etc.

We should instead keep raw Buffer<u8>s around and provide helpers to turn them into Cow<str> just in time, or something along these lines.

This of course extends to other types beyond strings; in fact it applies to any component with an inner type that is in and of itself plural: Binary, List<NativeT>, ...

@emilk
Copy link
Member

emilk commented Aug 30, 2023

@emilk
Copy link
Member

emilk commented Aug 30, 2023

@emilk emilk closed this as completed Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants