Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging API for "temporal batches" #4184

Closed
jleibs opened this issue Nov 8, 2023 · 3 comments · Fixed by #6587
Closed

Logging API for "temporal batches" #4184

jleibs opened this issue Nov 8, 2023 · 3 comments · Fixed by #6587
Assignees
Labels
enhancement New feature or request user-request This is a pressing issue for one of our users

Comments

@jleibs
Copy link
Member

jleibs commented Nov 8, 2023

When translating existing time-series plots to Rerun our logging APIs have very poor ergonomics.

A user must iterate through every sample, calling set_time with the time value, and then logging the individual scalars.

The proposal from:

Would let us optimize this a bit by passing the time values into the log-calls, but will still be order-N which can be quite painful for large time-series.

A direct temporal batch logging API would instead let us collapse this into a single call. For example:

rr.log_temporal_batch(timestamps=[...], ScalarBatch(...))

This would let us dramatically optimize the ingestion by letting us create a pre-batched uniform buffer of scalars that looks like what the eventual output of the batcher is going to be anyways.

@emilk
Copy link
Member

emilk commented Apr 22, 2024

@emilk emilk added the blocked can't make progress right now label Apr 22, 2024
@jleibs jleibs self-assigned this Jun 7, 2024
@jleibs jleibs removed the blocked can't make progress right now label Jun 11, 2024
@jleibs jleibs mentioned this issue Jun 17, 2024
6 tasks
@jleibs
Copy link
Member Author

jleibs commented Jun 18, 2024

Missing things to complete this workstream:

@jleibs
Copy link
Member Author

jleibs commented Jun 24, 2024

We should do a session on naming and usabillity of this prior to release 0.18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request user-request This is a pressing issue for one of our users
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants