Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re_datastore: IndexTable::latest_at early-exit on unknown component #529

Closed
2 tasks
Tracked by #443
teh-cmc opened this issue Dec 12, 2022 · 2 comments · Fixed by #596
Closed
2 tasks
Tracked by #443

re_datastore: IndexTable::latest_at early-exit on unknown component #529

teh-cmc opened this issue Dec 12, 2022 · 2 comments · Fixed by #596
Labels
⛃ re_datastore affects the datastore itself

Comments

@teh-cmc
Copy link
Member

teh-cmc commented Dec 12, 2022

Due to the way we build out our scenes, a very common thing that happens is that we query an entity path specifically looking for components that it knows nothing about.
This is fine, as long as we make sure to have a fast early-exit on that path. We currently don't.

There are actually many many ways to do this, with varying trade offs.
Depending on how we do this, we might actually be able to re-use this datastructure in order to help with #453 too!

  • IndexTables needs to keep track (efficiently) of what components they know of
  • IndexTable::latest_at needs to early-exit appropriately
@teh-cmc teh-cmc changed the title re_datastore: IndexTables need to keep track of the components they know of re_datastore: IndexTable::latest_at early-exit on unknown component Dec 12, 2022
@teh-cmc teh-cmc added the ⛃ re_datastore affects the datastore itself label Dec 12, 2022
@teh-cmc
Copy link
Member Author

teh-cmc commented Dec 12, 2022

Also, this is worth the introduction of an integration benchmark specifically targeting the use-case of querying for non-existing components.

@teh-cmc
Copy link
Member Author

teh-cmc commented Dec 19, 2022

This actually should just work out-of-the-box with the new PoV query model.

Still need to add a benchmark for good measure tho.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⛃ re_datastore affects the datastore itself
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant