Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Asset3D and EncodedImage look the same at the component level #7053

Open
jleibs opened this issue Aug 5, 2024 · 2 comments
Open

Asset3D and EncodedImage look the same at the component level #7053

jleibs opened this issue Aug 5, 2024 · 2 comments
Labels
🔩 data model
Milestone
0.18 - MHz logging

Comments

@jleibs
Copy link
Member

jleibs commented Aug 5, 2024 •
edited
Loading

There are potential weird behaviors in here:

  • In particular, we don't want a visualizer option to show an EncodedImage as an Asset3D
  • Additionally, logging Asset3D and a compressed image to the same entity will break in unexpected ways
@jleibs
Copy link
Member Author

jleibs commented Aug 5, 2024 •
edited by emilk
Loading

We might be able to punt on this until we have tagged components:

@emilk
Copy link
Member

emilk commented Aug 15, 2024

One symptom of this is that every EncodedImage has an option to add it to a 3D space view:

Screenshot 2024-08-15 at 09 46 17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🔩 data model
Projects
None yet
Milestone
0.18 - MHz logging
Development

No branches or pull requests
2 participants
@emilk @jleibs