Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the ListItem offscreen optimisation opt-out after 0.22 #8815

Open
abey79 opened this issue Jan 27, 2025 · 2 comments
Open

Make the ListItem offscreen optimisation opt-out after 0.22 #8815

abey79 opened this issue Jan 27, 2025 · 2 comments
Assignees
Labels
blocked can't make progress right now 🏎️ Quick Issue Can be fixed in a few hours or less ui concerns graphical user interface

Comments

@abey79
Copy link
Member

abey79 commented Jan 27, 2025

This PR introduces an opt-in offscreen optimisation for ListItem:

Let's make that opt-out right after the next release, to be on the safe side.

@abey79 abey79 added ui concerns graphical user interface 🏎️ Quick Issue Can be fixed in a few hours or less labels Jan 27, 2025
@abey79 abey79 self-assigned this Jan 27, 2025
@abey79 abey79 added the blocked can't make progress right now label Jan 27, 2025
@nikolausWest
Copy link
Member

Why not include it?

@abey79
Copy link
Member Author

abey79 commented Jan 27, 2025

When that PR lands (which is as soon as the other PR it's chained to lands), then that optimisation will be active where it maters (and where I've properly tested it): blueprint tree and streams tree. We're just postponing planet activation just to be on the safe side (and also because there is is next to nothing to be gained with it in most places where lists are short).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked can't make progress right now 🏎️ Quick Issue Can be fixed in a few hours or less ui concerns graphical user interface
Projects
None yet
Development

No branches or pull requests

2 participants