Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CollectAdditionalFilesToRemoveFromTarget fails via PackageReference #54

Closed
richardszalay opened this issue Mar 14, 2019 · 1 comment
Closed

CollectAdditionalFilesToRemoveFromTarget fails via PackageReference #54

richardszalay opened this issue Mar 14, 2019 · 1 comment
Milestone
1.5.2

Comments

@richardszalay
Copy link
Owner

richardszalay commented Mar 14, 2019 •
edited
Loading

From Helixbase/#20.

It looks like the targets file is imported before the MSBuild Web targets, so CollectAdditionalFilesToRemoveFromTarget ends up being the first dependency of WebFileSystemPublishDependsOn, before the files have been copied to the temp directory. On a fresh publish, our call to CollectFilesInFolder fails because $(WPPAllFilesInSingleFolder) doesn't exist.

Solution would be to add PipelineMsdeploySpecificTransformPhase to the dependencies of CollectAdditionalFilesToRemoveFromTarget
@richardszalay
Copy link
Owner Author

Confirmed, solution works as expected. Prepping release.

@richardszalay richardszalay added this to the 1.5.2 milestone Mar 14, 2019
This was referenced Mar 15, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.5.2
Development

No branches or pull requests
1 participant
@richardszalay