Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

riemann-riak error when adding tag #62

Closed
nifoc opened this issue Oct 15, 2013 · 2 comments
Closed

riemann-riak error when adding tag #62

nifoc opened this issue Oct 15, 2013 · 2 comments

Comments

@nifoc
Copy link

nifoc commented Oct 15, 2013

When trying to set a tag via the command line (--tag), riemann-riak fails with the following error: RuntimeError can't modify frozen String

Full stacktrace:

/Users/daniel/.gem/ruby/2.0.0/gems/beefcake-0.4.0/lib/beefcake/buffer/encode.rb:110:in `force_encoding'
/Users/daniel/.gem/ruby/2.0.0/gems/beefcake-0.4.0/lib/beefcake/buffer/encode.rb:110:in `append_string'
/Users/daniel/.gem/ruby/2.0.0/gems/beefcake-0.4.0/lib/beefcake/buffer/encode.rb:13:in `append'
/Users/daniel/.gem/ruby/2.0.0/gems/beefcake-0.4.0/lib/beefcake.rb:102:in `block in encode!'
/Users/daniel/.gem/ruby/2.0.0/gems/beefcake-0.4.0/lib/beefcake.rb:90:in `each'
/Users/daniel/.gem/ruby/2.0.0/gems/beefcake-0.4.0/lib/beefcake.rb:90:in `encode!'
/Users/daniel/.gem/ruby/2.0.0/gems/beefcake-0.4.0/lib/beefcake.rb:79:in `block in encode'
/Users/daniel/.gem/ruby/2.0.0/gems/beefcake-0.4.0/lib/beefcake.rb:72:in `each'
/Users/daniel/.gem/ruby/2.0.0/gems/beefcake-0.4.0/lib/beefcake.rb:72:in `encode'
/Users/daniel/.gem/ruby/2.0.0/gems/beefcake-0.4.0/lib/beefcake.rb:94:in `block in encode!'
/Users/daniel/.gem/ruby/2.0.0/gems/beefcake-0.4.0/lib/beefcake.rb:90:in `each'
/Users/daniel/.gem/ruby/2.0.0/gems/beefcake-0.4.0/lib/beefcake.rb:90:in `encode!'
/Users/daniel/.gem/ruby/2.0.0/gems/beefcake-0.4.0/lib/beefcake.rb:79:in `block in encode'
/Users/daniel/.gem/ruby/2.0.0/gems/beefcake-0.4.0/lib/beefcake.rb:72:in `each'
/Users/daniel/.gem/ruby/2.0.0/gems/beefcake-0.4.0/lib/beefcake.rb:72:in `encode'
/Users/daniel/.gem/ruby/2.0.0/gems/riemann-client-0.2.2/lib/riemann/client/udp.rb:40:in `block in send_maybe_recv'
/Users/daniel/.gem/ruby/2.0.0/gems/riemann-client-0.2.2/lib/riemann/client/udp.rb:57:in `block in with_connection'
/Users/daniel/.gem/ruby/2.0.0/gems/riemann-client-0.2.2/lib/riemann/client/udp.rb:54:in `synchronize'
/Users/daniel/.gem/ruby/2.0.0/gems/riemann-client-0.2.2/lib/riemann/client/udp.rb:54:in `with_connection'
/Users/daniel/.gem/ruby/2.0.0/gems/riemann-client-0.2.2/lib/riemann/client/udp.rb:39:in `send_maybe_recv'
/Users/daniel/.gem/ruby/2.0.0/gems/riemann-client-0.2.2/lib/riemann/client.rb:86:in `send_maybe_recv'
/Users/daniel/.gem/ruby/2.0.0/gems/riemann-client-0.2.2/lib/riemann/client.rb:49:in `<<'
/Users/daniel/.gem/ruby/2.0.0/gems/riemann-tools-0.1.4/lib/riemann/tools.rb:71:in `block in report'
/Users/daniel/.rubies/ruby-2.0.0-p247/lib/ruby/2.0.0/timeout.rb:66:in `timeout'
/Users/daniel/.gem/ruby/2.0.0/gems/riemann-tools-0.1.4/lib/riemann/tools.rb:70:in `report'
/Users/daniel/.gem/ruby/2.0.0/gems/riemann-tools-0.1.4/bin/riemann-riak:187:in `check_stats'
/Users/daniel/.gem/ruby/2.0.0/gems/riemann-tools-0.1.4/bin/riemann-riak:231:in `tick'
/Users/daniel/.gem/ruby/2.0.0/gems/riemann-tools-0.1.4/lib/riemann/tools.rb:90:in `block in run'
/Users/daniel/.gem/ruby/2.0.0/gems/riemann-tools-0.1.4/lib/riemann/tools.rb:88:in `loop'
/Users/daniel/.gem/ruby/2.0.0/gems/riemann-tools-0.1.4/lib/riemann/tools.rb:88:in `run'
/Users/daniel/.gem/ruby/2.0.0/gems/riemann-tools-0.1.4/lib/riemann/tools.rb:11:in `run'
/Users/daniel/.gem/ruby/2.0.0/gems/riemann-tools-0.1.4/bin/riemann-riak:237:in `<top (required)>'
/Users/daniel/.gem/ruby/2.0.0/bin/riemann-riak:23:in `load'
/Users/daniel/.gem/ruby/2.0.0/bin/riemann-riak:23:in `<main>'

I tried this using ruby 2.0.0p247 and ruby 1.9.3p448.

Edit 11:53:

The same thing is happening with riemann-redis, too. Did not check more tools.

@aphyr
Copy link
Collaborator

aphyr commented Oct 15, 2013

This is probably due to a change in Beefcake; seems to have introduced a regression. We may just be able to drop our use of frozen strings, though.

@aphyr
Copy link
Collaborator

aphyr commented Oct 15, 2013

Fixed in 0.1.5.

@aphyr aphyr closed this as completed Oct 15, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants