Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

riemann-redis run_id can be infinity #65

Closed
gsandie opened this issue Nov 11, 2013 · 2 comments · Fixed by #66
Closed

riemann-redis run_id can be infinity #65

gsandie opened this issue Nov 11, 2013 · 2 comments · Fixed by #66

Comments

@gsandie
Copy link
Contributor

gsandie commented Nov 11, 2013

Riemann-redis will convert the redis run_id to a float, this can come out as Infinity in ruby.

The run_id is a "Random value identifying the Redis server (to be used by Sentinel and Cluster)".

Rather than change the value to a float, I'd like to set it to nil or 0 as I think that more accurately reflects the run_id (the actual value will still be saved in the description).

Anyone using this value as a metric? Happy for this change?

@gsandie
Copy link
Contributor Author

gsandie commented Nov 11, 2013

I should also say, the infinity value causes exceptions in riemann:

2013-11-11_13:10:30.55487 WARN [2013-11-11 13:10:30,554] pool-1-thread-2 - riemann.streams - riemann.graphite$graphite$fn__15830@2891ffb4 threw
2013-11-11_13:10:30.55565 java.lang.IllegalArgumentException: Value out of range for float: Infinity

@ghost
Copy link

ghost commented Nov 11, 2013

Yeah, I think that's a good decision, Gavin.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant