-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please update this to at least stable 0.9.5 #2
Comments
Can i please get some assistance :) |
It really would be nice if Delta could get at-least-somewhat-vaguely-updated cores. I decided to take a look at each of the cores in Delta and compare their version with the latest upstream version, to get a general sense of the degree of old-itude. It's really bad.
Footnotes
|
After doing the research for the table above, I decided to look into things a bit further: for each Delta core, I checked the update history: how many times, and how far back, updates to the upstream core code actually occurred. (Note that the first item in each list is the version used to start with for the initial implementation, and then subsequent items—if any—constitute updates that happened after that.) NES2018-02-25: FCEUX 2.2.1(?) SNES2015-09-12: snes9x 1.53(?) GBC2017-04-13: gambatte f8a810b GBA2016-06-03: VBA-M 2.0.0b1(?) N642019-03-27: Mupen64Plus most-recent-git DS (DeSmuME)2019-08-05: DeSmuME most-recent-git DS (melonDS)2020-04-02: melonDS most-recent-git GEN2021-02-02: Genesis-Plus-GX most-recent-git Footnotes
|
So:
None of the cores (by which I mean the actual upstream emulator code) have been updated since Feb 2021. I spent several hours looking through commit logs and figuring out versions and so forth to write these comments. And now I'm just kind of depressed. Like... I get that the initial goal was to write this emulator... but then attention got diverted into developing AltStore because Delta wouldn't be able to be on the App Store... and so yeah that makes sense as an explanation for why Delta itself would get less care and attention. But like... now it is on the App Store, but with kinda-really-embarrassingly-not-updated cores. Including ones with known save corruption bugs, that the upstream developer is trying to get attention directed toward, that I guess just don't get updated anyway, because who cares. Sigh. |
@nadiaholmquist Consider updating the issue title to mention that this involves a KNOWN SAVE-CORRUPTION BUG affecting VERY POPULAR titles. That might make it slightly more likely to grab attention at a quick glance. |
@rileytestut Delta's melonDS core has a KNOWN SAVE CORRUPTION BUG AFFECTING VERY POPULAR MAINLINE POKEMON SERIES TITLES and needs to be updated. (I love your work and I support you on Patreon. But frankly, it's a little disappointing to find that most-to-all of Delta's cores could really, really use some updates to less-ancient upstream versions. And melonDS in particular would be ideal to look into first.) |
See also: this already-existent pull request from a few months back to at the very least bring Delta's forked melonDS repo up to 0.9.4. Looks like it might need a few small Delta-specific commits on top of 0.9.1 to be rebased. And it may as well bring things up to 0.9.5, if an update is to be done. I would literally just go ahead and make my own complete set of PRs that would update Delta's forked melonDS repo to 0.9.5; rebase the Delta-specific commits onto 0.9.5 where/as necessary; update the submodule reference in this repo; check for any code interface changes that might be needed here; and then do a full build of Delta to check for any compilation errors and run it in the simulator and then on a device to at least ensure that everything basically works. But unfortunately, as it currently stands, I don't have a macOS system + Xcode development environment handy and ready to go to facilitate that; and I'm neither an Objective-C nor a Swift person, I'm a C++ guy. Still, I would totally do that if it would make it any more likely that this gets acted upon. |
See also: several issue threads (linked to below) on the upstream melonDS GitHub in which, thanks to Delta's old-and-known-to-be-buggy melonDS core version, users have to be somewhat tediously helped by melonDS devs through the process of (1) getting their save file out of Delta, (2) running a specialized tool on it to fix it, and then (3) getting their save file back into Delta. melonDS-emu/melonDS#2016 (And this is just what's going on in GitHub issue threads, to say nothing of similar stuff happening on Discord etc.) |
Riley just announced this on Mastodon:
|
Fantastic! 😃 |
@nadiaholmquist |
Hey, just because you shipped the newer core in the paid "beta" version does not mean the issue is gone for everyone and we don't have to deal with it anymore. How about you actually get this resolved already? |
melonDS contributor here,
The version of melonDS you are shipping, which seems to be 0.9.1, has a bug in it with the pretty nasty consequence of corrupting people's Pokémon gen 5 progress.
The bug has been fixed, but as your port has not been updated for a long time we've had multiple people run into this issue and ask for help about it in our Discord, and with the release on the App Store this is only going to get more common.
I would suggest that you update to at least the 0.9.5 code ASAP so we all can avoid this support headache.
Edit: Let's keep a count of how many times we've had to deal with this upstream since Delta's App Store release!
Number of corrupted saves:
20I lost countThe text was updated successfully, but these errors were encountered: