Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech Debt: Minimize the scope of the global error callback #6525

Open
3 tasks
ericpgreen2 opened this issue Jan 29, 2025 · 0 comments
Open
3 tasks

Tech Debt: Minimize the scope of the global error callback #6525

ericpgreen2 opened this issue Jan 29, 2025 · 0 comments

Comments

@ericpgreen2
Copy link
Contributor

ericpgreen2 commented Jan 29, 2025

We have a longstanding global error handler at web-admin/src/features/errors/error-utils.ts. It was originally intended to handle common errors, provide easy-to-read error messages, and cover for the fact that components across the application did not do sufficient error handling themselves. But, this global error handler has long gone too far! We should:

  • Throw as many errors as possible in +layout.ts and +page.ts files
  • Ensure all major data-intensive components handle their own errors
  • Move easy-to-read error messages to a dedicated util function

Pages that don't currently handle their own errors, but should:

  • Project
  • Organization
  • Public URL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant