Explicitly use std::deque for the missing node handler stack: #2252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to ensure that pointers and/or references to existing elements will not be invalidated during the course of element insertion and removal. Containers like std::vector do not offer this guarantee, and cannot be used as the underlying container for the stack. By choosing to explicitly specify std::deque as the underlying cotnainer, we avoid: - the unlikely possibility of the C++ standards committee changing the default template parameter to a container; - the more likely possibility of an accidental change by a programmer, without fully considering the consequences.
Codecov Report
@@ Coverage Diff @@
## develop #2252 +/- ##
==========================================
- Coverage 70.11% 70.1% -0.02%
==========================================
Files 689 689
Lines 50800 50800
==========================================
- Hits 35617 35611 -6
- Misses 15183 15189 +6
Continue to review full report at Codecov.
|
HowardHinnant
approved these changes
Oct 26, 2017
bachase
added
the
Passed
|
Merged as f0e1024 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to ensure that pointers and/or references to existing elements will not be invalidated during the course of element insertion and removal.
Containers like
std::vectordo not offer this guarantee, and cannot be used as the underlying container for the stack.By choosing to explicitly specify std::deque as the underlying cotnainer, we avoid: