Include validator manifests in published list: #2278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manifests of validators newly added to a published validator list are not reliably propagated to network nodes. This solves the problem by allowing a published validator list to include the manifest. RIPD-1559
Codecov Report
@@ Coverage Diff @@
## develop #2278 +/- ##
==========================================
- Coverage 70.11% 70.1% -0.01%
==========================================
Files 689 689
Lines 50800 50815 +15
==========================================
+ Hits 35617 35626 +9
- Misses 15183 15189 +6
Continue to review full report at Codecov.
|
bachase
approved these changes
Nov 27, 2017
There was a problem hiding this comment.
👍 Can consider adding a test where the published list's validator manifest is older than one already available.
https://github.com/bachase/rippled/tree/bc-serve-manifests rebases #2242 on this changeset and adds the fold commit to include the current signing_keys in the validators RPC response.
|
Merged as bce9bca |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manifests of validators newly added to a published validator list are
not reliably propagated to network nodes.
This solves the problem by allowing a published validator list to
include the manifest.
RIPD-1559
This will need to be reconciled with the test changes in #2242