Improved error message on mistyped command [RIPD-1527] #2283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2283 +/- ##
===========================================
+ Coverage 70.22% 70.81% +0.58%
===========================================
Files 692 692
Lines 50961 51050 +89
===========================================
+ Hits 35787 36149 +362
+ Misses 15174 14901 -273
Continue to review full report at Codecov.
|
HowardHinnant
approved these changes
Nov 27, 2017
scottschurr
added
the
Passed
* Can be exercised from the command line with json2 * Rewrite Env::do_rpc to call the same code as rpc from the command line. This puts rpc handling logic in one place.
Previously if you mistyped the "submit_multisigned" command as "submit_multisign", the returned message was "Internal error". Not very helpful. It turns out this was caused by a small amount of code in RPCCall.cpp. Removing that code improves two situations: 1. It improves the situation with a mistyped command. Now the command returns "Unknown method" and provides the string of the mistyped command. 2. The "transaction_entry", if properly entered in its command line form, would fire an assert. That assert is now removed. In the process, it was discovered that the command line form of the "transaction_entry" command has not worked correctly for at least a year. Therefore support for that the command line form of "transaction_entry" is added along with appropriate unit tests.
scottschurr
force-pushed
the
howard-json2
branch
from
613dc6e to
0681702
Compare
|
Rebased to 0.80.1. |
|
In 0.90.0-b1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First things first; only the (currently) top-most commit needs to be reviewed. This pull request sits atop an earlier pull request from @HowardHinnant who is working in the same area.
Previously if you mistyped the "submit_multisigned" command as "submit_multisign", the returned message was "Internal error". Not very helpful. It turns out this was caused by a small amount of code in RPCCall.cpp. Removing that code improves two situations:
It improves the situation with a mistyped command. Now the command returns "Unknown method" and provides the string of the mistyped command.
The "transaction_entry" RPC command, if properly entered in its command line form, would fire an assert. That assert is now removed.
In the process, it was discovered that the command line form of the "transaction_entry" command has not worked correctly for at least a year. Therefore support for the command line form of "transaction_entry" is added along with appropriate unit tests.
Reviewers: @HowardHinnant for familiarity with RPC, @mellery451 for familiarity with TransactionEntry_test.cpp.