Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test logging fixes #2293

Closed
wants to merge 1 commit into from
Closed

Unit test logging fixes #2293

wants to merge 1 commit into from

Conversation

seelabs
Copy link
Collaborator

@seelabs seelabs commented Dec 6, 2017

  1. Check message queue before shutting down unit tests. Otherwise message may be lost.

  2. Logging should be on if not quiet. The multiprocess unit test commit changed this behavior. This commit changes it back.

* Check message queue before shutting down unit tests
* Logging should be on if not quiet
Copy link
Contributor

@mellery451 mellery451 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me now - 👍

@ripplelabs-jenkins
Copy link
Collaborator

ripplelabs-jenkins commented Dec 6, 2017

Jenkins Build Summary

Built from this commit

Built at 20171206 - 22:23:53

Test Results

Build Type Result Status
clang.debug.unity 970 cases, 0 failed, t: 370s PASS ✅
coverage 970 cases, 0 failed, t: 589s PASS ✅
gcc.debug.unity 970 cases, 0 failed, t: 420s PASS ✅
clang.debug.nounity 968 cases, 0 failed, t: 713s PASS ✅
gcc.debug.nounity 968 cases, 0 failed, t: 307s PASS ✅
clang.release.unity 969 cases, 0 failed, t: 437s PASS ✅
gcc.release.unity 969 cases, 0 failed, t: 457s PASS ✅

@codecov-io
Copy link

codecov-io commented Dec 6, 2017

Codecov Report

Merging #2293 into develop will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2293      +/-   ##
===========================================
- Coverage    70.96%   70.95%   -0.02%     
===========================================
  Files          691      691              
  Lines        51663    51663              
===========================================
- Hits         36661    36655       -6     
- Misses       15002    15008       +6
Impacted Files Coverage Δ
src/ripple/beast/clock/chrono_util.h 82.6% <0%> (-8.7%) ⬇️
src/ripple/app/ledger/PendingSaves.h 93.54% <0%> (-6.46%) ⬇️
src/ripple/json/impl/json_value.cpp 75% <0%> (-0.22%) ⬇️
src/ripple/app/main/Application.cpp 60.84% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 090d813...4a50d40. Read the comment docs.

@seelabs seelabs requested a review from HowardHinnant December 7, 2017 13:49
@seelabs seelabs added the Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. label Dec 7, 2017
@nbougalis nbougalis mentioned this pull request Jan 10, 2018
@seelabs
Copy link
Collaborator Author

seelabs commented Jan 16, 2018

In 0.90.0-b3

@seelabs seelabs closed this Jan 16, 2018
@seelabs seelabs deleted the unit-log branch July 11, 2018 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants