-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit test logging fixes #2293
Unit test logging fixes #2293
Conversation
* Check message queue before shutting down unit tests * Logging should be on if not quiet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works for me now - 👍
Jenkins Build SummaryBuilt from this commit Built at 20171206 - 22:23:53 Test Results
|
Codecov Report
@@ Coverage Diff @@
## develop #2293 +/- ##
===========================================
- Coverage 70.96% 70.95% -0.02%
===========================================
Files 691 691
Lines 51663 51663
===========================================
- Hits 36661 36655 -6
- Misses 15002 15008 +6
Continue to review full report at Codecov.
|
In 0.90.0-b3 |
Check message queue before shutting down unit tests. Otherwise message may be lost.
Logging should be on if not quiet. The multiprocess unit test commit changed this behavior. This commit changes it back.