-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update macos build instructions: #2342
Conversation
Added workaround for include path order anomaly with Xcode (discovered while testing the xcode build instructions)
Jenkins Build SummaryBuilt from this commit Built at 20180124 - 00:41:54 Test Results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me (and tests out fine). Thanks!
FWIW, the github rendered version of this document is here: https://github.com/mellery451/rippled/tree/mellery-macos-readme/Builds/macos (if that makes it easier to review) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only spotted one thing you might consider changing. Thanks for doing this.
Builds/macos/README.md
Outdated
ruby -e "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/master/install)" | ||
``` | ||
|
||
For more info, see "Step 3: Install Homebrew" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that should read, `see "Step 2: Install Homebrew".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch - I fixed the link and the text.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Afer setting up boost variable I also had to setup the
DYLD_LIBRARY_PATH vatiable and point it to "boost_1_65_1/stage/lib". Would be a good idea to add it to the documentation.
In 0.90.0-b5 |
Added workaround for include path order anomaly with Xcode (discovered
while testing the xcode build instructions)