Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update macos build instructions: #2342

Closed
wants to merge 2 commits into from
Closed

Update macos build instructions: #2342

wants to merge 2 commits into from

Conversation

mellery451
Copy link
Contributor

Added workaround for include path order anomaly with Xcode (discovered
while testing the xcode build instructions)

Added workaround for include path order anomaly with Xcode (discovered
while testing the xcode build instructions)
@ripplelabs-jenkins
Copy link
Collaborator

ripplelabs-jenkins commented Jan 19, 2018

Jenkins Build Summary

Built from this commit

Built at 20180124 - 00:41:54

Test Results

Build Type Result Status
coverage 975 cases, 0 failed, t: 615s PASS ✅
clang.debug.unity 975 cases, 0 failed, t: 386s PASS ✅
gcc.debug.unity 975 cases, 0 failed, t: 430s PASS ✅
clang.debug.nounity 973 cases, 0 failed, t: 620s PASS ✅
clang.release.unity 974 cases, 0 failed, t: 466s PASS ✅
gcc.debug.nounity 973 cases, 0 failed, t: 767s PASS ✅
gcc.release.unity 974 cases, 0 failed, t: 504s PASS ✅

Copy link
Contributor

@HowardHinnant HowardHinnant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me (and tests out fine). Thanks!

@mellery451
Copy link
Contributor Author

FWIW, the github rendered version of this document is here: https://github.com/mellery451/rippled/tree/mellery-macos-readme/Builds/macos (if that makes it easier to review)

Copy link
Collaborator

@scottschurr scottschurr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only spotted one thing you might consider changing. Thanks for doing this.

ruby -e "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/master/install)"
```

For more info, see "Step 3: Install Homebrew"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that should read, `see "Step 2: Install Homebrew".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch - I fixed the link and the text.

@mellery451 mellery451 added the Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. label Jan 24, 2018
Copy link
Contributor

@manojsdoshi manojsdoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Afer setting up boost variable I also had to setup the
DYLD_LIBRARY_PATH vatiable and point it to "boost_1_65_1/stage/lib". Would be a good idea to add it to the documentation.

@seelabs
Copy link
Collaborator

seelabs commented Jan 30, 2018

In 0.90.0-b5

@seelabs seelabs closed this Jan 30, 2018
@mellery451 mellery451 deleted the mellery-macos-readme branch February 1, 2018 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants