Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trivial: Reduce noise in log #2352

Closed
wants to merge 1 commit into from
Closed

Trivial: Reduce noise in log #2352

wants to merge 1 commit into from

Conversation

scottschurr
Copy link
Collaborator

@MarkusTeufelberger's suggestion here (#2346) makes sense to me. This small change will reduce some of the common noise in our logs.

@scottschurr scottschurr requested a review from ximinez January 24, 2018 17:38
@ripplelabs-jenkins
Copy link
Collaborator

Jenkins Build Summary

Built from this commit

Built at 20180124 - 18:05:22

Test Results

Build Type Result Status
clang.debug.unity 985 cases, 0 failed, t: 392s PASS ✅
coverage 985 cases, 0 failed, t: 622s PASS ✅
clang.debug.nounity 983 cases, 0 failed, t: 305s PASS ✅
gcc.debug.nounity 983 cases, 0 failed, t: 333s PASS ✅
gcc.debug.unity 985 cases, 0 failed, t: 441s PASS ✅
clang.release.unity 984 cases, 0 failed, t: 475s PASS ✅
gcc.release.unity 984 cases, 0 failed, t: 477s PASS ✅

ximinez
ximinez approved these changes Jan 25, 2018
View reviewed changes
Copy link
Collaborator

@ximinez ximinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward 👍

@scottschurr scottschurr added the Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. label Jan 25, 2018
@seelabs
Copy link
Collaborator

seelabs commented Jan 30, 2018

In 0.90.0-b5

@seelabs seelabs closed this Jan 30, 2018
@scottschurr scottschurr deleted the offer-log branch February 17, 2018 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ximinez ximinez ximinez approved these changes

Assignees

@ximinez ximinez

Labels
Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@scottschurr @ripplelabs-jenkins @seelabs @ximinez