Trivial: Add missing includes #2368
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins Build SummaryBuilt from this commit Built at 20180206 - 00:35:35 Test Results
|
|
I hope you didn't have to type out my name every time there. :-D It's 1:1 PR #2338 squashed down, so I hope that at least these parts of ripplebeast will build in the future. 👍 |
Closed
scottschurr
force-pushed
the
marcus-patch-22-squash
branch
from
768e96e to
e694317
Compare
|
Rebased to 0.90.0-b6. |
scottschurr
added
the
Passed
|
Merged in 531e153 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@MarkusTeufelberger identified some of our source files that were missing includes. This branch contains @MarkusTeufelberger's commits, squashed. Thanks @MarkusTeufelberger.
Simultaneously, @MarkusTeufelberger also identified a hole in our non-unity build process. We'll be looking into that hole and hopefully addressing it in the future.
The changes are trivial, so I'm only asking for one on-team reviewer. I'd also appreciate it if @MarkusTeufelberger would glance over the branch to make sure I didn't miss anything.
Reviewers: @bachase and @MarkusTeufelberger.