Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[trivial] Change check invariant failure log level to fatal #2154

Closed
wants to merge 1 commit into from

Conversation

seelabs
Copy link
Collaborator

@seelabs seelabs commented Jun 23, 2017

No description provided.

@seelabs seelabs requested a review from ximinez June 23, 2017 21:59
@codecov-io
Copy link

Codecov Report

Merging #2154 into develop will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2154      +/-   ##
===========================================
- Coverage    69.01%   68.99%   -0.03%     
===========================================
  Files          684      684              
  Lines        50468    50468              
===========================================
- Hits         34833    34818      -15     
- Misses       15635    15650      +15
Impacted Files Coverage Δ
src/ripple/app/tx/impl/ApplyContext.cpp 100% <100%> (ø) ⬆️
src/ripple/app/misc/detail/WorkBase.h 69.81% <0%> (-11.33%) ⬇️
src/ripple/basics/DecayingSample.h 77.77% <0%> (-8.34%) ⬇️
src/ripple/app/ledger/PendingSaves.h 93.54% <0%> (-6.46%) ⬇️
src/ripple/app/misc/impl/ValidatorSite.cpp 78.47% <0%> (-0.7%) ⬇️
src/ripple/server/impl/BaseWSPeer.h 67.5% <0%> (-0.63%) ⬇️
src/ripple/core/impl/JobQueue.cpp 86.32% <0%> (-0.48%) ⬇️
src/ripple/app/ledger/impl/LedgerMaster.cpp 44.04% <0%> (-0.23%) ⬇️
src/ripple/protocol/impl/Serializer.cpp 70.3% <0%> (+0.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b0d482...42e8ac3. Read the comment docs.

Copy link
Collaborator

@ximinez ximinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nbougalis
Copy link
Contributor

Merged as d831328

@nbougalis nbougalis closed this Jul 10, 2017
@seelabs seelabs deleted the log-level branch July 13, 2017 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants