Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append default port (51235) in [ips_fixed] when no port specified #2861

Closed
alloynetworks opened this issue Feb 21, 2019 · 5 comments
Closed
Labels
Bug Good First Issue Great issue for a new contributor

Comments

@alloynetworks
Copy link
Contributor

If a port is not specified against an IP in [ips_fixed], rippled fails to start. The daemon should try with the default port if it is not specified.

@nbougalis nbougalis added the Bug label Feb 21, 2019
@nbougalis
Copy link
Contributor

Yep that’s a bug. Thanks for reporting it!

@nbougalis nbougalis added the Good First Issue Great issue for a new contributor label Feb 21, 2019
@alloynetworks
Copy link
Contributor Author

This fix should also apply to [ips].

@MarkusTeufelberger
Copy link
Collaborator

The example config currently says "A port may must be specified after adding a space to the address."

b39c1eb sounds like this was intentionally set to "must", so this is a feature, not a bug.

@nbougalis
Copy link
Contributor

While the original intent may have been to require a port number, it doesn't mean this isn't a bug, albeit not a code bug. The decision to mandate a port when a port isn't mandatory in any other instance is, at best, curious. Our config is complex enough as is; having arcane differences here and there is not good.

I believe that this should be corrected.

@movitto
Copy link
Contributor

movitto commented May 11, 2019

Figured this would be a good easy one to get my feet wet with rippled contributions! Just submitted a first stab, let me know if specific changes are needed/preferred.

gregtatcam added a commit to gregtatcam/rippled that referenced this issue Jan 28, 2020
gregtatcam added a commit to gregtatcam/rippled that referenced this issue Jan 28, 2020
gregtatcam added a commit to gregtatcam/rippled that referenced this issue Mar 6, 2020
gregtatcam added a commit to gregtatcam/rippled that referenced this issue Mar 26, 2020
gregtatcam added a commit to gregtatcam/rippled that referenced this issue Mar 26, 2020
gregtatcam added a commit to gregtatcam/rippled that referenced this issue Apr 27, 2020
gregtatcam added a commit to gregtatcam/rippled that referenced this issue Apr 27, 2020
manojsdoshi pushed a commit to manojsdoshi/rippled that referenced this issue May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Good First Issue Great issue for a new contributor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants