-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Append default port (51235) in [ips_fixed] when no port specified #2861
Comments
Yep that’s a bug. Thanks for reporting it! |
This fix should also apply to |
The example config currently says "A port may must be specified after adding a space to the address." b39c1eb sounds like this was intentionally set to "must", so this is a feature, not a bug. |
While the original intent may have been to require a port number, it doesn't mean this isn't a bug, albeit not a code bug. The decision to mandate a port when a port isn't mandatory in any other instance is, at best, curious. Our config is complex enough as is; having arcane differences here and there is not good. I believe that this should be corrected. |
Figured this would be a good easy one to get my feet wet with rippled contributions! Just submitted a first stab, let me know if specific changes are needed/preferred. |
If a port is not specified against an IP in
[ips_fixed]
,rippled
fails to start. The daemon should try with the default port if it is not specified.The text was updated successfully, but these errors were encountered: