Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Travis to bionic #3319

Closed
wants to merge 1 commit into from
Closed

Update Travis to bionic #3319

wants to merge 1 commit into from

Conversation

gliptak
Copy link
Contributor

@gliptak gliptak commented Mar 26, 2020

No description provided.

@nbougalis
Copy link
Contributor

Thanks for your contribution. Other than testing on the "latest and greatest" is there a particular benefit we derive from this?

@nbougalis nbougalis requested a review from manojsdoshi March 29, 2020 03:19
@gliptak
Copy link
Contributor Author

gliptak commented Mar 29, 2020

While xenial is nearing EOL https://wiki.ubuntu.com/Releases at this time PR targets keeping up.

@carlhua carlhua self-requested a review April 3, 2020 13:52
@carlhua
Copy link
Contributor

carlhua commented Apr 3, 2020

@manojsdoshi can we make sure that our package building is also upgraded - namely the ubuntu docker image?

@gliptak
Copy link
Contributor Author

gliptak commented Apr 3, 2020

https://github.com/ripple/rippled/blob/b54d672710227e494dd774c3ca3a4bc0a9976233/Builds/containers/ubuntu-builder/Dockerfile#L1 ? Am I to add to this PR?

@carlhua
Copy link
Contributor

carlhua commented Apr 3, 2020

https://github.com/ripple/rippled/blob/b54d672710227e494dd774c3ca3a4bc0a9976233/Builds/containers/ubuntu-builder/Dockerfile#L1

? Am I to add to this PR?

Yep!

@gliptak
Copy link
Contributor Author

gliptak commented Apr 3, 2020

@carlhua updated

carlhua
carlhua approved these changes Apr 3, 2020
View reviewed changes
Copy link
Contributor

@carlhua carlhua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

manojsdoshi
manojsdoshi reviewed Apr 10, 2020
View reviewed changes
Copy link
Contributor

@manojsdoshi manojsdoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

manojsdoshi
manojsdoshi approved these changes Apr 10, 2020
View reviewed changes
Copy link
Contributor

@manojsdoshi manojsdoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nbougalis nbougalis mentioned this pull request Apr 15, 2020
Merged
@carlhua carlhua added the Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. label Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlhua carlhua carlhua approved these changes

@manojsdoshi manojsdoshi manojsdoshi approved these changes

Assignees
No one assigned
Labels
Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gliptak @nbougalis @carlhua @manojsdoshi