Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to RocksDB 6.7.3 #3356

Closed
wants to merge 2 commits into from

Conversation

miguelportilla
Copy link
Contributor

No description provided.

@carlhua
Copy link
Contributor

carlhua commented Apr 14, 2020

Can we revert out the changes in this PR as part this PR so that we can see if CI works vs waiting till this gets merged in?

https://github.com/ripple/rippled/pull/3303/files

Thanks!

@codecov-io
Copy link

codecov-io commented Apr 14, 2020

Codecov Report

Merging #3356 into develop will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #3356   +/-   ##
========================================
  Coverage    70.46%   70.47%           
========================================
  Files          684      684           
  Lines        55001    55001           
========================================
+ Hits         38759    38762    +3     
+ Misses       16242    16239    -3     
Impacted Files Coverage Δ
src/ripple/basics/DecayingSample.h 86.48% <0.00%> (+8.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f422f6...3284dec. Read the comment docs.

@miguelportilla
Copy link
Contributor Author

@carlhua done.

@carlhua carlhua self-requested a review April 15, 2020 13:46
Copy link
Contributor

@carlhua carlhua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thejohnfreeman thejohnfreeman changed the title Update to RocksBD 6.7.3 Update to RocksDB 6.7.3 Apr 17, 2020
@carlhua carlhua added the Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. label Apr 21, 2020
This was referenced Apr 23, 2020
@miguelportilla miguelportilla deleted the rocksdb_update branch April 30, 2020 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants