Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TRIVIAL] Fixes for gcc 10 #3393

Closed
wants to merge 1 commit into from
Closed

[TRIVIAL] Fixes for gcc 10 #3393

wants to merge 1 commit into from

Conversation

seelabs
Copy link
Collaborator

@seelabs seelabs commented May 8, 2020

Gcc 10 fails to compile rippled without this change.

@seelabs seelabs requested a review from cjcobb23 May 8, 2020 23:59
@codecov-io
Copy link

Codecov Report

Merging #3393 into develop will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3393      +/-   ##
===========================================
- Coverage    70.44%   70.43%   -0.02%     
===========================================
  Files          682      682              
  Lines        54392    54392              
===========================================
- Hits         38315    38309       -6     
- Misses       16077    16083       +6     
Impacted Files Coverage Δ
src/ripple/rpc/handlers/AccountTx.cpp 85.23% <100.00%> (ø)
src/ripple/server/impl/BaseHTTPPeer.h 85.96% <0.00%> (-3.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9771210...1cca80e. Read the comment docs.

@seelabs seelabs added the Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. label May 11, 2020
This was referenced May 21, 2020
@seelabs seelabs deleted the gcc-10 branch May 27, 2020 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants