Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use NuDB version 2.0.3 #3437

Closed
wants to merge 1 commit into from
Closed

Use NuDB version 2.0.3 #3437

wants to merge 1 commit into from

Conversation

miguelportilla
Copy link
Contributor

Update the CMake NuDB file to use tag 2.0.3

@miguelportilla miguelportilla requested review from seelabs, ximinez and a user June 3, 2020 19:48
ximinez
ximinez approved these changes Jun 3, 2020
View reviewed changes
Copy link
Collaborator

@ximinez ximinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wiped out my .nih_c and build directories, and cmake had no problem finding NuDB, building rippled, and running unittests. LGTM.

seelabs
seelabs approved these changes Jun 4, 2020
View reviewed changes
Copy link
Collaborator

@seelabs seelabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran the same test that Ed did. 👍

@seelabs seelabs added the Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. label Jun 4, 2020
@ghost ghost mentioned this pull request Jun 4, 2020
Closed
ghost
ghost approved these changes Jun 4, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compiled and run tests along with Deterministic Shards PR.

This was referenced Jun 25, 2020
Closed
Closed
Closed
Merged
@miguelportilla miguelportilla deleted the nudb_203 branch August 11, 2020 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ximinez ximinez ximinez approved these changes

@seelabs seelabs seelabs approved these changes

Assignees

@seelabs seelabs

@ximinez ximinez

Labels
Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miguelportilla @seelabs @ximinez