-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forward validations and manifests in reporting mode #3905
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, did you test this at all?
Yea, set it up locally and tried out the |
Can we hook it up to the validations-mainnet bot and make sure everything works correctly? |
Sure, do you have an instance running anywhere? Or should I just set that up locally? |
I don't have an instance; is it a pain to setup locally? |
nah I just might not get to it til next week |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this. Everything looks good.
@@ -374,7 +374,7 @@ class ETLLoadBalancer | |||
/// @param in ETLSource in question |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update the documentation for this function which currently only describes the transaction stream.
@@ -354,12 +358,30 @@ ETLSource::handleMessage() | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do the shouldPropagateStream() check once instead of in 3 places. Then, if the check passes, check for each of the stream types and proceed accordingly.
This removes duplicated code and I think makes the intention more clear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
High Level Overview of Change
Forwards
validations
andmanifest
subscription streams in reporting mode.Context of Change
In order for reporting mode to be deployed to s1 and s2, it must support subscriptions to the
validations
andmanifests
streams.This PR adds those streams in the same manner as
transactions_proposed
.validationReceived
andmanifestReceived
messages are forwarded from the ETL Source to subscribers.Type of Change