Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

absolute paths for conffile in debian pkg #3909

Closed
wants to merge 1 commit into from

Conversation

legleux
Copy link
Collaborator

@legleux legleux commented Aug 20, 2021

High Level Overview of Change

Install of deb packages will fail on new Debian 11 Bullseye with error:
dpkg: error processing archive build/dpkg/packages/rippled_1.8.0~b4-1_amd64.deb (--install): conffile name 'opt/ripple/etc/rippled.cfg' is not an absolute pathname

Context of Change

Absolute paths weren't enforced in deb packages before.
https://git.dpkg.org/cgit/dpkg/dpkg.git/commit/?id=15416a18f7645dbb9a36edb1e52f30a9e83c6627

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (You added tests for code that already exists, or your new feature included in this PR)
  • Documentation Updates
  • Release

Copy link
Collaborator

@ximinez ximinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed one of the Travis builds failed, and I cleared the cache and am re-running the dependency steps before I try that one. However, since this change doesn't affect the build at all, that's no reason to hold this up.

@scottschurr
Copy link
Collaborator

@manojsdoshi, do you have any comments on this pull request? With your approval we could mark it as passed. Thanks.

Copy link
Contributor

@manojsdoshi manojsdoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manojsdoshi manojsdoshi added the Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. label Sep 8, 2021
@manojsdoshi manojsdoshi mentioned this pull request Sep 9, 2021
@nbougalis nbougalis mentioned this pull request Sep 9, 2021
@legleux legleux deleted the fix-deb-pkg-deb11 branch September 17, 2021 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants