Changes required due to libxrpl refactor #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bronek
approved these changes
Jun 26, 2024
There was a problem hiding this comment.
Two non-binding comments
- consider squashing both commits
- consider separating non-xrpl includes from xrpl ones, such that 1) own headers go first, then empty line, then 2) xrpl includes, then empty line, then 3) C++ and boost includes (can be in one block together)
legleux
force-pushed
the
phy_redesign_changes
branch
from
792eed6 to
adbf1ca
Compare
Bronek
approved these changes
Jun 27, 2024
Comment on lines
-49
to
+55
| Priority: 0 | ||
| - Regex: '^<(ripple)/' | ||
| - Regex: '^<xrpl/.*>' | ||
| Priority: 2 | ||
| - Regex: '^<(test)/' | ||
| Priority: 1 | ||
| - Regex: '^<.*\.h>' | ||
| Priority: 0 |
There was a problem hiding this comment.
I generally prefer listing these in ascending priority order. Just noting for next time.
ximinez
added a commit
to ximinez/validator-keys-tool
that referenced
this pull request
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XRPLF/rippled#5050 moved things