2019 + address prefixed tags #7
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@intelliot
I wrote this lib back in the day. If you want I can help you modernize/fix it (prettier-standard/typescript/create-hash etc)
Obviously not anywhere near ready yet. This was just to get a POC of tagged addresses keeping the original ripple address at the beginning of the encoded data.
We probably don't want to bring in all of oer-utils, which depends upon bn.js. Given only using a few r/w methods, could probably just copy/paste a subset of it. Basically just need to be able to use the standard BER/DER/OER varint length encoding