Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use sum type for expects in records #202

Merged
merged 5 commits into from
Nov 12, 2023
Merged

Conversation

BugenZhao
Copy link
Collaborator

@BugenZhao BugenZhao commented Nov 9, 2023

Resolve #200 (review).

Hide the whitespaces for better review experiences. :)

@BugenZhao BugenZhao requested a review from xxchan November 9, 2023 08:51
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Copy link
Member

@wangrunji0408 wangrunji0408 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skyzh skyzh force-pushed the bz/sum-type-in-records branch from c19aa7e to a0851b9 Compare November 12, 2023 04:26
@skyzh skyzh merged commit 0919ca0 into main Nov 12, 2023
4 checks passed
@skyzh skyzh deleted the bz/sum-type-in-records branch November 12, 2023 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants