Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support DELETE in TableV2 #16

Closed
Tracked by #408
TennyZhuang opened this issue Jan 24, 2022 · 3 comments · Fixed by #962
Closed
Tracked by #408

support DELETE in TableV2 #16

TennyZhuang opened this issue Jan 24, 2022 · 3 comments · Fixed by #962
Assignees

Comments

@TennyZhuang
Copy link
Contributor

No description provided.

@BugenZhao
Copy link
Member

Table V2 is currently ready for batch query. Considering there're a lot of blockers now, if the purpose is to test record deletion in streaming e2e tests, maybe the best quickest way is still to implement delete for Bummock table.😢

@TennyZhuang
Copy link
Contributor Author

Table V2 is currently ready for batch query. Considering there're a lot of blockers now, if the purpose is to test record deletion in streaming e2e tests, maybe the best quickest way is still to implement delete for Bummock table.😢

  1. Implement deletion on Bummock table is non-trivial.
  2. Eventually, we should implement deletion on TableV2.

If it's not ready, when is the correct time to implement it?

In my opinion, there is no blockers to add the DeleteExecutor.

@BugenZhao
Copy link
Member

MV on MV (Table V2) is temporally unavailable since we're migrating barrier manager to meta service these days. It's certainly okay to implement DeleteExecutor now, but one can't test it on materialized view until the MV on MV becomes available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants