Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metrics: fragment -> fragment and worker node -> worker node exchange throughput #2986

Closed
skyzh opened this issue Jun 5, 2022 · 4 comments · Fixed by #3696
Closed

metrics: fragment -> fragment and worker node -> worker node exchange throughput #2986

skyzh opened this issue Jun 5, 2022 · 4 comments · Fixed by #3696
Assignees
@marvenlee2486
Labels
component/streaming Stream processing related issue. good first issue Good for newcomers type/feature

Comments

@skyzh
Copy link
Contributor

skyzh commented Jun 5, 2022

Currently, we have actor -> actor throughput. However, when parallelism gets very high, the metrics could be hard to be stored and analyzed. Therefore, it's better to have a fragment-level or worker node level exchange info.
@skyzh
Copy link
Contributor Author

skyzh commented Jun 6, 2022

cc @StrikeW do you have interest in implementing this? 🤣

@StrikeW
Copy link
Contributor

StrikeW commented Jun 6, 2022

I think this can be a good first issue.☺️

@StrikeW StrikeW added good first issue Good for newcomers component/streaming Stream processing related issue. labels Jun 6, 2022
@skyzh
Copy link
Contributor Author

skyzh commented Jun 6, 2022

That's cool 🤤

@marvenlee2486 marvenlee2486 self-assigned this Jun 7, 2022
@StrikeW
Copy link
Contributor

StrikeW commented Jun 8, 2022

The actor -> actor exchange metrics is this PR. FYI. @marvenlee2486

@marvenlee2486 marvenlee2486 mentioned this issue Jul 6, 2022
Merged
@mergify mergify bot closed this as completed in #3696 Jul 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marvenlee2486 marvenlee2486

Labels
component/streaming Stream processing related issue. good first issue Good for newcomers type/feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(metrics): Add Fragment Level Exchange Metrics risingwavelabs/risingwave
3 participants
@skyzh @StrikeW @marvenlee2486