Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: need a common notification service client #3679

Closed
zwang28 opened this issue Jul 6, 2022 · 1 comment · Fixed by #3754
Closed

refactor: need a common notification service client #3679

zwang28 opened this issue Jul 6, 2022 · 1 comment · Fixed by #3754
Assignees
@xxhZs
Labels
type/feature

Comments

@zwang28
Copy link
Contributor

zwang28 commented Jul 6, 2022 •
edited
Loading

Is your feature request related to a problem? Please describe.
Currently only frontend node uses meta's notification service. It uses ObserverManager as client, which contains RPC streaming maintenance and some fe specific code.

Actually storage crate need access to notification service too, to sync meta data like hummock version/compaction group. So we may want a common notification service client.

Describe the solution you'd like
A common notification service client shared by other crates.

Describe alternatives you've considered

Additional context
@zwang28 zwang28 self-assigned this Jul 8, 2022
@xxhZs xxhZs self-assigned this Jul 8, 2022
@zwang28 zwang28 removed their assignment Jul 8, 2022
@zwang28 zwang28 mentioned this issue Jul 8, 2022
Merged
1 task
@xxhZs xxhZs mentioned this issue Jul 8, 2022
Merged
3 tasks
@xxhZs xxhZs linked a pull request Jul 8, 2022 that will close this issue
feat(common): move observer_manager to common service #3754
Merged
3 tasks
@BugenZhao
Copy link
Member

Might related: #672 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xxhZs xxhZs

Labels
type/feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(common): move observer_manager to common service risingwavelabs/risingwave
3 participants
@BugenZhao @zwang28 @xxhZs