From f5f044338cfec54fb91ca775d5502fce4ced4c03 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=96zg=C3=BCr=20Akkurt?=
 <91746947+ozgrakkurt@users.noreply.github.com>
Date: Tue, 7 Feb 2023 07:48:29 +0300
Subject: [PATCH] Renamed `factory` argument on parquet read functions to
 `reader_factory` (#1380)

* rename factory param to reader_factory

* fix mistake
---
 src/io/parquet/read/row_group.rs | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/io/parquet/read/row_group.rs b/src/io/parquet/read/row_group.rs
index e17dba30fed..176c6e83182 100644
--- a/src/io/parquet/read/row_group.rs
+++ b/src/io/parquet/read/row_group.rs
@@ -139,14 +139,14 @@ where
 }
 
 async fn _read_single_column_async<'b, R, F>(
-    factory: F,
+    reader_factory: F,
     meta: &ColumnChunkMetaData,
 ) -> Result<(&ColumnChunkMetaData, Vec<u8>)>
 where
     R: AsyncRead + AsyncSeek + Send + Unpin,
     F: Fn() -> BoxFuture<'b, std::io::Result<R>>,
 {
-    let mut reader = factory().await?;
+    let mut reader = reader_factory().await?;
     let (start, length) = meta.byte_range();
     reader.seek(std::io::SeekFrom::Start(start)).await?;
 
@@ -169,13 +169,13 @@ pub async fn read_columns_async<
     R: AsyncRead + AsyncSeek + Send + Unpin,
     F: Fn() -> BoxFuture<'b, std::io::Result<R>> + Clone,
 >(
-    factory: F,
+    reader_factory: F,
     columns: &'a [ColumnChunkMetaData],
     field_name: &str,
 ) -> Result<Vec<(&'a ColumnChunkMetaData, Vec<u8>)>> {
     let futures = get_field_columns(columns, field_name)
         .into_iter()
-        .map(|meta| async { _read_single_column_async(factory.clone(), meta).await });
+        .map(|meta| async { _read_single_column_async(reader_factory.clone(), meta).await });
 
     try_join_all(futures).await
 }
@@ -309,7 +309,7 @@ pub async fn read_columns_many_async<
     R: AsyncRead + AsyncSeek + Send + Unpin,
     F: Fn() -> BoxFuture<'b, std::io::Result<R>> + Clone,
 >(
-    factory: F,
+    reader_factory: F,
     row_group: &RowGroupMetaData,
     fields: Vec<Field>,
     chunk_size: Option<usize>,
@@ -321,7 +321,7 @@ pub async fn read_columns_many_async<
 
     let futures = fields
         .iter()
-        .map(|field| read_columns_async(factory.clone(), row_group.columns(), &field.name));
+        .map(|field| read_columns_async(reader_factory.clone(), row_group.columns(), &field.name));
 
     let field_columns = try_join_all(futures).await?;