Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the possibility to disable dwarf source line information #653

Closed
xarkes opened this issue Feb 18, 2021 · 3 comments · Fixed by #3511
Closed

Add the possibility to disable dwarf source line information #653

xarkes opened this issue Feb 18, 2021 · 3 comments · Fixed by #3511
Assignees
Labels
DWARF enhancement New feature or request good first issue Good for newcomers PDB

Comments

@xarkes
Copy link
Member

xarkes commented Feb 18, 2021

Is your feature request related to a problem? Please describe.

Currently if one wants to hide the information of source line, one has to do e asm.dwarf=false which might remove other useful dwarf information as well.
We discussed it in a PR for Cutter here rizinorg/cutter#2600 and I'll detail the solution we thought would be the best.

Describe the solution you'd like

  • Rename asm.pdb.lines to asm.debug.lines
  • When dwarf information is available:
    • If asm.dwarf=true and asm.debug.lines=false hide dwarf source line information
    • If asm.dwarf=false hide dwarf source line information anyways

Feel free to edit this issue in order to add more details.

@ret2libc
Copy link
Member

I think what you suggest make sense and it should be fairly easy to do, however in practice at the moment I am not sure which additional information get included with asm.dwarf=true. Do you have an example where this is an actual problem? Apart from that anyway, the feature sounds good to me and makes sense.

@XVilka
Copy link
Member

XVilka commented Mar 18, 2021

@thestr4ng3r maybe you could include this in our DWARF refactoring PR too?

@thestr4ng3r
Copy link
Member

Yes, this can be done. But line information is conceptually independent of dwarf as dwarf is just one possible source of information for it.

@XVilka XVilka assigned ghost May 18, 2021
@stale stale bot added the stale label Nov 20, 2021
@rizinorg rizinorg deleted a comment from stale bot Nov 20, 2021
@stale stale bot removed the stale label Nov 20, 2021
@stale stale bot added the stale label May 25, 2022
@rizinorg rizinorg deleted a comment from stale bot May 25, 2022
@stale stale bot removed the stale label May 25, 2022
@ret2libc ret2libc added enhancement New feature or request stale labels May 25, 2022
@stale stale bot removed the stale label May 25, 2022
@Sidhub723 Sidhub723 mentioned this issue Apr 4, 2023
5 tasks
@XVilka XVilka assigned imbillow and unassigned ghost May 8, 2023
@imbillow imbillow mentioned this issue May 14, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DWARF enhancement New feature or request good first issue Good for newcomers PDB
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants