Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor RzBinFile.sdb_addrinfo out of Sdb #843

Closed
thestr4ng3r opened this issue Mar 16, 2021 · 0 comments · Fixed by #880
Closed

Refactor RzBinFile.sdb_addrinfo out of Sdb #843

thestr4ng3r opened this issue Mar 16, 2021 · 0 comments · Fixed by #880
Assignees
Labels
refactor Refactoring requests RzBin

Comments

@thestr4ng3r
Copy link
Member

Sdb *sdb_addrinfo;

This is an sdb with records like 0x424242=some/filename.c:1337, next to some other entries where the dwarf code abuses this sdb for completely different purposes.
This could be done much better in either a hashtable or even better a tree (so queries like "closest addr info" are possible). Also the filenames should be in a string pool to reduce bloat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactoring requests RzBin
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant