Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crypt3 non-optional again? #171

Closed
ciaranj opened this issue Nov 26, 2014 · 5 comments
Closed

Crypt3 non-optional again? #171

ciaranj opened this issue Nov 26, 2014 · 5 comments

Comments

@ciaranj
Copy link

ciaranj commented Nov 26, 2014

Hiyah, has #119 been regressed again as I can't seem to install 1.0.0-alpha on a windows machine again. I'm not familiar with the 'bundleDependencies' setting in package.json, but crypt3 appears in there as well as in 'dependencies' (again) as well as in 'optionalDependencies' ?

@rlidwka
Copy link
Owner

rlidwka commented Nov 27, 2014

#119 is my mistake, but I'm not sure this one is. crypt3 does not appear in "dependencies".

The intention is:

  • it is bundled, so people won't have to download it from the registry (and we'll have fixed version each time it is installed)
  • it is optional, so people who can't compile it can live without it (with less features available)

Could you please file this against npm/npm repository with all the debug information?

@ciaranj
Copy link
Author

ciaranj commented Nov 27, 2014

Ok, odd. I've checked what's published up on npm and you're right (of course) crypt3 isn't appearing in the 'dependencies' property. I thought it was yesterday, but I've tried on another machine and an 'npm install sinopia' on windows will attempt to build crypt3, and if it fails will not continue the install.

@rlidwka
Copy link
Owner

rlidwka commented Nov 27, 2014

Filed as npm/npm#6801 .

@ciaranj
Copy link
Author

ciaranj commented Nov 27, 2014

Beat me to it, I was reading around the docs to see if it was a known issue ;)

@rlidwka
Copy link
Owner

rlidwka commented Nov 30, 2014

I published [email protected], now it's using npm-shrinkwrap instead of bundled dependencies.

So it should work now; npm issue still exists though.

@rlidwka rlidwka closed this as completed Nov 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants