Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRA v2 now has support for SCSS modules #15

Closed
benknight opened this issue Sep 19, 2018 · 4 comments
Closed

CRA v2 now has support for SCSS modules #15

benknight opened this issue Sep 19, 2018 · 4 comments

Comments

@benknight
Copy link

https://github.com/facebook/create-react-app/blob/next/packages/react-scripts/config/webpack.config.dev.js#L37

Added here: facebook/create-react-app#4195

This issue is to resync this repo with the latest v2 config so that this project can be used with components that use SCSS modules until CRA v2 is released.

This was mentioned in the comments on #13 after it was closed, but there was no follow up by the author. Opening a new issue for reconsideration.

@ro-savage
Copy link
Owner

Apologises, I didn't get notifications for those comments.

@benknight @danoc - Happy to take a PR to bring this package up to date with SCSS changes from CRAv2.

@danoc
Copy link

danoc commented Sep 23, 2018

Thanks, @ro-savage — I won't have time to work on this, but maybe @benknight is interested. FWIW, CRA v2 is expected to be released within the next two weeks: facebook/create-react-app#5024

@ro-savage
Copy link
Owner

Once CRA v2 is released, this package will stop being updated/maintained.

Still happy for someone to do a PR, but for most people, just upgrading to CRA v2 is the much better option as it includes many enhancements.

@benknight
Copy link
Author

Agreed, I created this issue just before learning that CRA v2 was about to be released. Willing to wait for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants