From 676ff55371201429fecc300835182789f1e1246e Mon Sep 17 00:00:00 2001
From: Ambroise Maupate <ambroise@rezo-zero.com>
Date: Tue, 26 Nov 2024 17:25:54 +0100
Subject: [PATCH] fix: Fixed early access of AbstractEmbedFinder::$feed

---
 lib/Documents/src/MediaFinders/AbstractEmbedFinder.php | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/lib/Documents/src/MediaFinders/AbstractEmbedFinder.php b/lib/Documents/src/MediaFinders/AbstractEmbedFinder.php
index 1ae4f5e2..967b09df 100644
--- a/lib/Documents/src/MediaFinders/AbstractEmbedFinder.php
+++ b/lib/Documents/src/MediaFinders/AbstractEmbedFinder.php
@@ -26,7 +26,7 @@
  */
 abstract class AbstractEmbedFinder implements EmbedFinderInterface
 {
-    protected array|\SimpleXMLElement|null $feed;
+    protected array|\SimpleXMLElement|null $feed = null;
     protected string $embedId;
     protected ?string $key = null;
 
@@ -93,11 +93,8 @@ public function exists(): bool
     public function getFeed(): array|\SimpleXMLElement|null
     {
         if (null === $this->feed) {
-            $rawFeed = $this->getMediaFeed();
-            if ($rawFeed instanceof StreamInterface) {
-                $rawFeed = $rawFeed->getContents();
-            }
-            if (null !== $rawFeed) {
+            $rawFeed = $this->getMediaFeed()->getContents();
+            if (null !== $rawFeed && \json_validate($rawFeed)) {
                 $feed = json_decode($rawFeed, true);
                 if (is_array($feed)) {
                     $this->feed = $feed;