Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefixer falls back to prefixAll in Chromium 50 #84

Closed
sunflowerdeath opened this issue May 30, 2016 · 3 comments
Closed

Prefixer falls back to prefixAll in Chromium 50 #84

sunflowerdeath opened this issue May 30, 2016 · 3 comments

Comments

@sunflowerdeath
Copy link

sunflowerdeath commented May 30, 2016

Prefixer falls back to prefixAll in Chromium 50:

new Prefixer({userAgent: 'Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Ubuntu Chromium/50.0.2661.102 Chrome/50.0.2661.102 Safari/537.36'}).prefix({display: 'flex'})
> Object {display: Array[5]}

prefixer._browserInfo
> {
    name: "Chromium",
    chromium": true,
    version: 50,
    blink: true,
    linux: true,
    x: true,
    browser: "",
    osversion: null
}

For example, with user agent from Firefox 46 it works:

new Prefixer({userAgent: 'Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:46.0) Gecko/20100101 Firefox/46.0'}).prefix({display: 'flex'})

> Object {display: "flex"}

Also, it works in Chrome.

Probably you need to add 'chromium' to this file https://github.com/rofrischmann/inline-style-prefixer/blob/master/modules/utils/getBrowserInformation.js on 4 and 10 lines.

@robinweser
Copy link
Owner

Do you know if Chromium and Chrome's versions always match according to features? Then we could really Chromium as an actual Chrome, else we would set version to 0 telling to use all Webkit prefixes as there's no way to keep track of all different browser versions / feature support except those listed on caniuse.com

@sunflowerdeath
Copy link
Author

sunflowerdeath commented May 31, 2016

Yes, they always match.
https://www.chromium.org/developers/version-numbers

MAJOR and MINOR track updates to the Google Chrome stable channel.

@robinweser
Copy link
Owner

Fixed by @karinepires with #86

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants