Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Determine and document minimum supported rust version (MSRV) #14

Merged
merged 1 commit into from
Oct 21, 2021
Merged

Determine and document minimum supported rust version (MSRV) #14

merged 1 commit into from
Oct 21, 2021

Conversation

robo9k
Copy link
Owner

@robo9k robo9k commented Oct 21, 2021

This was done using cargo msrv with cargo test on Linux.

CI has not been adjusted to have a build matrix for MSRV. MSRV and current stable should be built for all platforms in a future merge request.

@robo9k
Copy link
Owner Author

robo9k commented Oct 21, 2021 •
edited
Loading

Turns out Rust 1.38.0-x86_64-pc-windows-msvc is not compatible with cargo-vcpkg, so cargo install cargo-vcpkg fails for Windows CI.
Workaround is to cargo +stable install cargo-vcpkg and then continue with the build as usual.

@robo9k robo9k merged commit e0cad12 into main Oct 21, 2021
@robo9k robo9k deleted the msrv branch October 21, 2021 14:56
@robo9k
Copy link
Owner Author

robo9k commented Oct 21, 2021

MSRV is also relevant for #5 , readme has been updated in this merge request already.

@robo9k robo9k mentioned this pull request Oct 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@robo9k