BufferManager: add configuration methods and examples enhancement #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
S-Dafarra
reviewed
Jan 27, 2021
traversaro
reviewed
Jan 27, 2021
README.md
Outdated
| {"two",{1,1}} }, 3); | ||
| yarp::telemetry::BufferManager<int32_t> bm(n_samples); | ||
| bm.setFileName("buffer_manager_test.mat"); | ||
| ChannelInfo var_one{ "one", {1,1} }; |
There was a problem hiding this comment.
I think yarp::telemetry is missing in several of this examples.
There was a problem hiding this comment.
For now I put yarp::telemetry in the latest example that is the one that is in the README, we should remove all the using namespace yarp::telemetry
traversaro
approved these changes
Jan 28, 2021
S-Dafarra
reviewed
Jan 28, 2021
| std::map<std::string, dimensions_t> m_dimensions_map; | ||
| bool m_auto_save{false}; | ||
| size_t m_n_samples{0}; | ||
| std::unordered_map<std::string, Buffer<T>> m_buffer_map; |
There was a problem hiding this comment.
I guess that also the corresponding include should change
There was a problem hiding this comment.
Thanks for the tip, I didn't know that there was a specific header!
Nicogene
force-pushed
the
feat/buffManagerExternalConf
branch
from
181b322 to
1ed6276
Compare
Nicogene
commented
Jan 29, 2021
| m_buffer_map.insert(std::pair<std::string, yarp::telemetry::Buffer<T>>(s.m_var_name,Buffer<T>(n_samples))); | ||
| m_dimensions_map.insert(std::pair<std::string, yarp::telemetry::dimensions_t>(s.m_var_name, s.m_dimensions)); | ||
| } | ||
| assert(addChannels(channels) == true); |
There was a problem hiding this comment.
With @AlexAntn we spotted that is a bug, in Release the addChannels is not invoked because assert is skipped
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some configuration methods, now you are no more forced to configure the BufferManager at the construction phase.
The examples have been cleaned up and refactored accordingly.
Please review code.
cc @S-Dafarra