Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WL: Add reinstall feature for rockons #2022

Open
wiza opened this issue Feb 26, 2019 · 9 comments
Open

WL: Add reinstall feature for rockons #2022

wiza opened this issue Feb 26, 2019 · 9 comments

Comments

@wiza
Copy link

wiza commented Feb 26, 2019

Reinstall feature for upgrading rockons. Basically one button that stops, deletes and reinstalls the rockon. Previously entered values presented on the install phase.

@wiza
Copy link
Author

wiza commented Sep 28, 2021

Any chance this getting any resolution?

@phillxnet
Copy link
Member

@wiza Given we have a number of thumbs-up on this and @FroggyFlox is one of them the likelihood is high, but the time-frame is another thing. This would involve adding an additional feature and we are now in feature freeze readying for our re-launch of sorts via the new v4 "Build on openSUSE" endeavour. See our release notes for 4.0.9-0 Release Candidate 10 from yesterday:

https://forum.rockstor.com/t/beta-built-on-opensuse-testing-channel-changelog/7097/16

Post this phase concluding and us starting up a new testing channel, branch based this time, this would be a good candidate for early inclusion. Especially since I believe we have now added, in the interim from your original feature request, a Rock-ons config restore component that in turn has this very mechanism as part of it's make-up, or at least the major building blocks of it.

Linking to the most relevant progress pull requests in this area for future consideration:

[Config Backup & Restore] Implement backup and restore of rock-ons #2100 (released in 3.9.2-52 Jan 2020)

Implement docker networks. Fixes #1982. #2207 (released in 4.0.5-0 Jan 2021)

Replace orphaned django-ztask with Huey (#2276) #2283 (released in 4.0.6-0 March 21)

With each in turn having a number of bug fixes along the way.

@FroggyFlox
Copy link
Member

Hi @wiza ,

@phillxnet already detailed pretty much everything and I agree with the fact that it's a high priority update once we get back into implementing changes like that.
As mentioned, all building blocks are already there so this would mostly require putting them all together in the desired way.
One of the reasons this has been on our radar for a while is the idea of providing a one-button way to update a Rock-on. Was that what you had in mind or would you simply like to see a way to reinstall a Rock-On without necessarily pulling the newest image(s) available?

@wiza
Copy link
Author

wiza commented Sep 28, 2021

Mostly updating containers but I have also created some of my own rockons and while developing fast way to delete/install would be great :)

@FroggyFlox
Copy link
Member

Sounds good!
Our current "install" procedure uses docker run's defaults, which means it'll look for an updated image and pull if there is one. This means a current reinstall will update the container to the latest image as well. I'll admit I've not looked into whether one can disable that docker run behavior but it might be nice to offer a way for users not to automatically do so... It'll probably be good for a follow-up if there's interest, though, so that we can keep this issue more focused.
By curiosity, would you have an idea/preference of how we should present this "reinstall" button? Should it be straight on the main Rock-Ons page next to start/stop, or in the Rock-On advanced settings? I personally favor the latter as I would like to keep the main Rock-Ons page as clean as possible for simplicity.

@wiza
Copy link
Author

wiza commented Sep 28, 2021

It could be with start/stop on installed page or just list all the available rock-ons on the All-page (currently running are now not shown) with install changed to reinstall?

@Hooverdan96
Copy link
Member

@wiza, @FroggyFlox it has been a while on this topic, but I am wondering whether the Watchtower Rockon we are offering provides essentially that option (whether it's run on a periodic cron job or manually triggered)?

@FroggyFlox
Copy link
Member

@Hooverdan96: good question... I hadn't considered/thought whether Watchtower would fit this need.

Personally, I still would like to have a "reinstall" button as described by @wiza as I found myself doing the manual Stop + Uninstall + Install + post-install customization for a few Rock-Ons and really would have loved that "reinstall" button to simplify the process. We already have most of the logic in place thanks to our rock-on update mechanism used for post-install customization so I'm hopeful that adding this button would not require too much additional logic. That being said, these are famous last words.

I guess my answer above mostly illustrate my unfamiliarity with Watchtower, though... For instance, can you manually trigger the update of a container with a click of a button, or is it only via a scheduled task or cli trigger?

@Hooverdan96
Copy link
Member

If you set up Watchtower Rockon without the cron job piece, you can have it sitting as turned off. Once turned on, it will execute the check and perform the reinstall. Once complete you can turn Watchtower off again. that way you retain control over when/where you want updates to occur. However, it will scan all installed Rockons that have a watchtower tag/label maintained.

So, having the reinstall button I think is a good idea, as it's just "there" and very focused on that particular Rockon. So, let's keep it open for now, and we can still decide at some point whether it's too much work compared to other priorities ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants