Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: reporting error hooks #703

Closed
dadah89 opened this issue Mar 22, 2018 · 4 comments
Closed

Feature request: reporting error hooks #703

dadah89 opened this issue Mar 22, 2018 · 4 comments
Assignees
Milestone

Comments

@dadah89
Copy link

dadah89 commented Mar 22, 2018

Hi all,

Recently was dealing with an internal error, and also noticed that sometimes I'd get 500 responses from the server (async). Was looking for hooks so I could track / monitor those situations, but couldn't find any. End up adding a code like this:

Rollbar::Notifier.prepend(Module.new do
   def handle_response(response)
      if response.code != '200'
        # tracking
      end
      super
    end

    def report_internal_error(exception)
      # tracking
      super
    end
end)

Would be really nice if there were hooks for async responses and internal errors when configuring Rollbar.

@dadah89 dadah89 changed the title Feature request: reporting error hook Feature request: reporting error hooks Mar 22, 2018
@rivkahstandig3636 rivkahstandig3636 added this to the v2.16.0 milestone Apr 2, 2018
@rivkahstandig3636
Copy link
Contributor

Thanks for the request!

@ArturMoczulski
Copy link
Contributor

Implemented and will be included in release v2.18.0

@ArturMoczulski
Copy link
Contributor

Documentation on usage can now found here: https://docs.rollbar.com/v1.0.0/docs/gem-configuration-reference

@ArturMoczulski ArturMoczulski modified the milestones: v2.19.0, v2.18.0 Sep 26, 2018
@dadah89
Copy link
Author

dadah89 commented Oct 7, 2018

@ArturMoczulski thanks for the change, appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants