Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncation does not always produce a small-enough payload #864

Closed
brianr opened this issue May 7, 2019 · 2 comments · Fixed by #865
Closed

Truncation does not always produce a small-enough payload #864

brianr opened this issue May 7, 2019 · 2 comments · Fixed by #865
Assignees

Comments

@brianr
Copy link
Member

brianr commented May 7, 2019

Example seen from rollbar-gem 2.12.0:

Failsafe from rollbar-gem. Could not send payload due to it being too large after truncating attempts. Original size: 81038972 Final size: 1386110

We ought to at least be able to report something more useful than that. Let's try to figure out what kind of situation this might have been, and figure out a truncation strategy that would produce something useful.

@letaniaferreira
Copy link

@waltjones
Copy link
Contributor

#872 released in 2.20.1 does more to address this, by also removing the contents of request and then extra if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants