Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify rack env key for user ip address #1065

Merged
merged 1 commit into from
Sep 2, 2021
Merged

Conversation

waltjones
Copy link
Contributor

Description of the change

Allows a config override to select the rack env key for the user IP. This solves the Cloudflare scenario in #1064 as well as any others where the default keys and/or precedence order need an override.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fixes ch90310
Fixes #1064

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@waltjones waltjones merged commit c9a21b4 into master Sep 2, 2021
@waltjones waltjones requested a review from bxsx October 18, 2021 17:34
@waltjones waltjones deleted the wj-config-user-ip-key branch June 27, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using actionpack-cloudflare to set proper remote_ip isn't making it's way to rollbar
2 participants