Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing require #1117

Merged
merged 1 commit into from
Dec 19, 2022
Merged

Add missing require #1117

merged 1 commit into from
Dec 19, 2022

Conversation

waltjones
Copy link
Contributor

Description of the change

Adds the missing require for Rollbar::JSON::JsOptionsState.

Type of change

  • Bug fix (non-breaking change that fixes an issue)

Related issues

Fixes #1100

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@waltjones waltjones merged commit 29edec0 into master Dec 19, 2022
@waltjones waltjones deleted the waltjones/1100/missing-require branch June 27, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulserraino paulserraino paulserraino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v3.3.1 - Causes breaking change - RollbarJS no longer loading
2 participants
@waltjones @paulserraino