Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Rails 7.1 to CI and fix compatibility issue with DebugExceptions#render_exception #1132

Merged
merged 5 commits into from
Oct 12, 2023
Merged

Add Rails 7.1 to CI and fix compatibility issue with DebugExceptions#render_exception #1132

merged 5 commits into from
Oct 12, 2023

Conversation

waltjones
Copy link
Contributor

@waltjones waltjones commented Oct 11, 2023 •
edited
Loading

Description of the change

This PR updates CI to include Rails 7.1, and fixes a compatibility issue with DebugExceptions#render_exception.

This PR also includes CI updates required to update from Ubuntu 18.04 to 20.04 in Github Actions.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • Maintenance

Related issues

Fixes: #1122

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@waltjones waltjones changed the title Waltjones/rails 7.1 compat Add Rails 7.2 to CI and fix compatibility issue with DebugExceptions#render_exception Oct 11, 2023
@waltjones waltjones changed the title Add Rails 7.2 to CI and fix compatibility issue with DebugExceptions#render_exception Add Rails 7.1 to CI and fix compatibility issue with DebugExceptions#render_exception Oct 12, 2023
@waltjones waltjones force-pushed the waltjones/rails-7.1-compat branch from 1ff8607 to 607d243 Compare October 12, 2023 11:45
csaba-ilonka-rollbar
csaba-ilonka-rollbar approved these changes Oct 12, 2023
View reviewed changes
Copy link

@csaba-ilonka-rollbar csaba-ilonka-rollbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@waltjones waltjones merged commit 8130206 into master Oct 12, 2023
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csaba-ilonka-rollbar csaba-ilonka-rollbar csaba-ilonka-rollbar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Swallowing errors on Rails 7.1
2 participants
@waltjones @csaba-ilonka-rollbar