Bug undefined blank for string in Rollbar::Logger #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rollbar does not have ActiveSupport as
a runtime dependency in gemspec and it is
not required in Rollbar::Logger but is used.
way to reproduce:
```irb
require 'rollbar/logger'
Rollbar::Logger.new.error("foo")
# NoMethodError: undefined method `blank?' for "foo":String
```
can be worked arround by requiring
`active_support/core_ext/object/blank`
```irb
require 'rollbar/logger'
require 'active_support/core_ext/object/blank'
Rollbar::Logger.new.error("foo")
# => "disabled"
```
Check if message responds to :blank?, if it does not use a local implementation of it. local implementation taken from https://github.com/rails/rails/blob/v5.1.4/activesupport/lib/active_support/core_ext/object/blank.rb#L17
|
@duksis why not just add a dependency on |
|
@ArturMoczulski it's always good to keep your dependencies as minimal as possible. at the end it's a decision that the maintainers have to make: 4 lines with a guard clause and 1 line copied from core ext |
|
@duksis that's a good point |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible solution to close #674 - feel free to use it or not to :)
Implements a local blank for usage without core_ext
Check if message responds to :blank?, if it does not
use a local implementation of it.
local implementation taken from
https://github.com/rails/rails/blob/v5.1.4/activesupport/lib/active_support/core_ext/object/blank.rb#L17