Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework gem regex spec to avoid deprecation warning. #788

Merged
merged 1 commit into from
Jan 2, 2019
Merged

Rework gem regex spec to avoid deprecation warning. #788

merged 1 commit into from
Jan 2, 2019

Conversation

boone
Copy link
Contributor

@boone boone commented Oct 31, 2018

Currently the specs are outputting this warning:

NOTE: Dependency.new w/ a regexp is deprecated.
Dependency.new called from .../lib/ruby/2.2.0/rubygems/specification.rb:910

In #120, the warning was fixed in the main code but not the specs. This PR fixes the specs using the same lookup.

This will also help future-proof the specs, as calling Gem::Specification.find_all_by_name with a regex in Ruby 2.4+ will raise an exception:

NoMethodError: undefined method `upcase' for /rspec/:Regexp

@jessewgibbs
Copy link
Contributor

@boone thanks for the contribution.

@ArturMoczulski can you review this?

@ArturMoczulski ArturMoczulski merged commit 5ab50c0 into rollbar:master Jan 2, 2019
@ArturMoczulski
Copy link
Contributor

Looks great @boone thanks for PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ejoubaud ejoubaud ejoubaud approved these changes

Assignees

@ArturMoczulski ArturMoczulski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@boone @jessewgibbs @ArturMoczulski @ejoubaud