Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Ruby 1.8.7, 1.9.2 from Travis matrix, and update gemspec #822

Merged
merged 3 commits into from
Feb 20, 2019

Conversation

waltjones
Copy link
Contributor

@waltjones waltjones commented Feb 14, 2019

Maintenance ended on Ruby 1.8.7 and 1.9.2 in 2014, including security updates. The latest Rails they work with is 3.x, and especially 1.8.7 doesn't support modern Ruby syntax, which holds back the gem code from using preferred syntax. Finally, in spite of their limited use and usefulness, it's not uncommon for a PR to need special treatment for these in the Travis matrix. RIP.

(Any users of these Ruby versions can still pin to an earlier version of rollbar-gem.)

Todo: Decide what version bump is appropriate for the change in gemspec requirements. (Ruby >= 1.9.3)

  • Update version.rb and readme.md with correct gem version.

@waltjones waltjones force-pushed the wj-drop-ruby-187-192 branch from 7dcdc5a to 639f3b1 Compare February 14, 2019 20:34
@waltjones waltjones force-pushed the wj-drop-ruby-187-192 branch from 639f3b1 to b853638 Compare February 14, 2019 21:29
@ArturMoczulski
Copy link
Contributor

@rokob @coryvirok how do you guys feel about dropping support for Ruby < 1.9.3 ? Do we have any users still using such legacy versions?

@waltjones waltjones merged commit 082d36c into master Feb 20, 2019
@coryvirok
Copy link
Contributor

I don't know the answer to your question, @ArturMoczulski. I would be very careful to not break backward compatibility in the gem though. If this is important enough, I think we can get the data but it'll take some time.

@waltjones waltjones deleted the wj-drop-ruby-187-192 branch June 27, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants